[webkit-reviews] review granted: [Bug 49385] Reduce the size of the RegexStackSpaceForBackTrackInfoParentheses in YARR : [Attachment 73615] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 10 19:22:31 PST 2010


Gavin Barraclough <barraclough at apple.com> has granted Peter Varga
<pvarga at inf.u-szeged.hu>'s request for review:
Bug 49385: Reduce the size of the RegexStackSpaceForBackTrackInfoParentheses in
YARR
https://bugs.webkit.org/show_bug.cgi?id=49385

Attachment 73615: proposed patch
https://bugs.webkit.org/attachment.cgi?id=73615&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Hmmm, think I added these at an early state of development, thinking PCRE's
behaviour of coalescing results across repeated iterations of karen matching
was correct (ie. /(?:(a)|(b))/.exec(ab) as ["ab", "a", "b"], rather than 
["ab", , "b"]).  Anyway, good catch, yes, these look like garbage now.


More information about the webkit-reviews mailing list