[webkit-reviews] review denied: [Bug 50636] contentEditable attribute fails to take "inherit" or invalid value : [Attachment 76233] fix patch 3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 10 15:59:47 PST 2010


Darin Adler <darin at apple.com> has denied Chang Shu <Chang.Shu at nokia.com>'s
request for review:
Bug 50636: contentEditable attribute fails to take "inherit" or invalid value
https://bugs.webkit.org/show_bug.cgi?id=50636

Attachment 76233: fix patch 3
https://bugs.webkit.org/attachment.cgi?id=76233&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Thanks for adding more test coverage. I still don’t think we have enough.
Specifically, if I call setAttribute("contenteditable", "x") and then
getAttribute("contenteditable"), what do I get? I suspect the current patch
handles that case wrong.


More information about the webkit-reviews mailing list