[webkit-reviews] review granted: [Bug 50844] Implement Download::start() and Download::startWithHandle() on WebKit2 (Windows) : [Attachment 76264] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Ada Chan <adachan at apple.com>'s
request for review:
Bug 50844: Implement Download::start() and Download::startWithHandle() on
WebKit2 (Windows)
https://bugs.webkit.org/show_bug.cgi?id=50844

Attachment 76264: Patch
https://bugs.webkit.org/attachment.cgi?id=76264&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=76264&action=review

> WebKit2/WebProcess/Downloads/cf/DownloadCFNet.cpp:122
> +    CFRetain(request);

Please add a comment here - "CFNetwork requires us to return a retained
request" or something.

> WebKit2/WebProcess/Downloads/cf/DownloadCFNet.cpp:158
> +    if (!destination.isNull()) {

Could just do an early return here.