[webkit-reviews] review requested: [Bug 22759] dropdown menu disappears on mouse-over : [Attachment 76248] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 10 13:29:42 PST 2010


dgrogan at google.com has asked  for review:
Bug 22759: dropdown menu disappears on mouse-over
https://bugs.webkit.org/show_bug.cgi?id=22759

Attachment 76248: patch
https://bugs.webkit.org/attachment.cgi?id=76248&action=review

------- Additional Comments from dgrogan at google.com
Don't round lengths if specified units are pixels.  Round everything else.

I think this is more correct than the current behaviour but it moves a lot of
stuff by 1 pixel.  Including h2 and h3 elements that are seemingly ubiquitous
in pixel tests, of which approximately 200 are affected.  I've looked at all of
them except some of the mozilla table tests.  None indicate that this patch
breaks anything, they're all either improvements (minority) or noise
(majority).

(same substance as attachment 76229, fixed style errors)


More information about the webkit-reviews mailing list