[webkit-reviews] review granted: [Bug 50839] commit-queue should report port/platform information when commenting on flaky test bugs : [Attachment 76246] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 10 13:27:10 PST 2010


Tony Chang <tony at chromium.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 50839: commit-queue should report port/platform information when commenting
on flaky test bugs
https://bugs.webkit.org/show_bug.cgi?id=50839

Attachment 76246: Patch
https://bugs.webkit.org/attachment.cgi?id=76246&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76246&action=review

> WebKitTools/Scripts/webkitpy/common/system/platform.py:39
> +	   return platform.platform(aliased=1, terse=1)

Heh, on my linux machine, this returns
Linux-2.6.32-26-generic-pae-i686-with-glibc2.4.

> WebKitTools/Scripts/webkitpy/tool/bot/flakytestreporter.py:103
> +	   bot_id_string = "Bot Id: %s " % (bot_id) if bot_id else ""
> +	   return "%sPort: %s OS: %s" % (bot_id_string,
self._tool.port().name(), self._tool.platform.display_name())

Nit: When I have lots of params, I normally switch to using the dictionary
style replacements.


More information about the webkit-reviews mailing list