[webkit-reviews] review requested: [Bug 47759] Crash while processing ill-formed <textPath> ouside of <text> : [Attachment 76244] Fix and layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 10 13:00:46 PST 2010


Cosmin Truta <ctruta at chromium.org> has asked  for review:
Bug 47759: Crash while processing ill-formed <textPath> ouside of <text>
https://bugs.webkit.org/show_bug.cgi?id=47759

Attachment 76244: Fix and layout test
https://bugs.webkit.org/attachment.cgi?id=76244&action=review

------- Additional Comments from Cosmin Truta <ctruta at chromium.org>
Resubmitting with the layout test slightly changed:
"This should not be rendered." --> "This should not appear in rendering."

With the new test, if the text is inadvertently (incorrectly) rendered, the
text descent (the lower part of 'p' in "appear" and the lower part of 'g' in
"rendering") shows up as dirt in the rendered image, thus making the failure
more obvious, even when it's not crashing.

Could you please redo the r+/cq+?


More information about the webkit-reviews mailing list