[webkit-reviews] review granted: [Bug 50514] WebKit2: Context menu support on Windows : [Attachment 76237] [PATCH] Reordering ContextMenu{Item}.h

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 50514: WebKit2: Context menu support on Windows
https://bugs.webkit.org/show_bug.cgi?id=50514

Attachment 76237: [PATCH] Reordering ContextMenu{Item}.h
https://bugs.webkit.org/attachment.cgi?id=76237&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=76237&action=review

> WebCore/platform/ContextMenu.cpp:45
> +	   if (const ContextMenuItem* subMenuItem = findItemWithAction(action,
const_cast<Vector<ContextMenuItem>&>(item.subMenuItems())))

No need for the const_cast here anymore.

> WebCore/platform/ContextMenu.h:52
> +	   ContextMenuItem* itemWithAction(unsigned);

Looks like you forgot to remove this from the #else case.