[webkit-reviews] review granted: [Bug 50679] Web Inspector: eliminate SourceFrameDelegate by passing scripts to SourceFrame constructor : [Attachment 76186] Do not regress live edit in ScriptView.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 50679: Web Inspector: eliminate SourceFrameDelegate by passing scripts to
SourceFrame constructor
https://bugs.webkit.org/show_bug.cgi?id=50679

Attachment 76186: Do not regress live edit in ScriptView.
https://bugs.webkit.org/attachment.cgi?id=76186&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76186&action=review

> WebCore/inspector/front-end/SourceFrame.js:811
> +	   if (script.resource)

I think this can be encapsulated in script.source setter.

> WebCore/inspector/front-end/SourceFrame.js:826
> +	   return WebInspector.debuggerModel.findBreakpoints(function(b) {
return b.sourceID in scripts; });

nit: findBreakpoints -> queryBreakpoints.