[webkit-reviews] review granted: [Bug 50814] [GTK] AX: implement isEnabled in DRT : [Attachment 76195] Patch proposal
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 10 07:38:02 PST 2010
Martin Robinson <mrobinson at webkit.org> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 50814: [GTK] AX: implement isEnabled in DRT
https://bugs.webkit.org/show_bug.cgi?id=50814
Attachment 76195: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=76195&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76195&action=review
Nice patch! Please incorporate the small cleanup suggested below before
landing.
> WebKitTools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:382
> + bool result =
static_cast<bool>(atk_state_set_contains_state(stateSet.get(), stateType));
> +
> + return result;
This can just be: return atk_state_set_contains_state(stateSet.get(),
stateType)
More information about the webkit-reviews
mailing list