[webkit-reviews] review granted: [Bug 50606] WebKit2: Need a WebKit2 equivalent of the WebKit1 WebDatabaseManager : [Attachment 76147] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Jessie Berlin
<jberlin at webkit.org>'s request for review:
Bug 50606: WebKit2: Need a WebKit2 equivalent of the WebKit1 WebDatabaseManager
https://bugs.webkit.org/show_bug.cgi?id=50606

Attachment 76147: Patch
https://bugs.webkit.org/attachment.cgi?id=76147&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=76147&action=review

Is it possible to add some API tests for this?

You should probably have Sam give the new API a once-over.

> WebKit2/DerivedSources.make:28
> +    $(WebKit2)/WebProcess/WebCoreSupport \

Is this really needed? We don't have any .messages.in files in WebCoreSupport,
do we?

> WebKit2/UIProcess/WebDatabaseManagerProxy.cpp:64
> +    m_databaseOriginsCallbacks.set(callbackID, callback.get());

You can use callback.release() here to save a ref/deref.

> WebKit2/UIProcess/WebDatabaseManagerProxy.cpp:81
> +	  
securityOrigins->append(WebSecurityOrigin::create(originIdentifiers[i]).leakRef
());

Who is in charge of dereffing these objects?