[webkit-reviews] review granted: [Bug 50804] [chromium] Reduce canvas.toDataURL("image/jpeg") run-time cost by 10% : [Attachment 76174] patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted noel gordon <noel.gordon at gmail.com>'s
request for review:
Bug 50804: [chromium] Reduce canvas.toDataURL("image/jpeg") run-time cost by
10%
https://bugs.webkit.org/show_bug.cgi?id=50804

Attachment 76174: patch
https://bugs.webkit.org/attachment.cgi?id=76174&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76174&action=review

It's a little surprising that this unroll makes things faster, but OK.	 Are
you certain in the stability of your numbers?

> WebCore/platform/image-encoders/skia/JPEGImageEncoder.cpp:90
> +	   if ((alpha != 0) && (alpha != 255)) {

We generally use just "alpha" instead of "alpha != 0", but it might be OK here.