[webkit-reviews] review canceled: [Bug 50750] [Qt][WK2] Add the QWKContext API class to wrap the WebContext. : [Attachment 76048] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has canceled Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 50750: [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
https://bugs.webkit.org/show_bug.cgi?id=50750

Attachment 76048: Patch
https://bugs.webkit.org/attachment.cgi?id=76048&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
(In reply to comment #2)
> (From update of attachment 76048 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=76048&action=review
> 
> > WebKit2/UIProcess/API/qt/qwkcontext.h:36
> > +	 // Bridge from the C API
> > +	 QWKContext(WKPageNamespaceRef pageNamespaceRef, QObject* parent = 0);
> 
> Do we need this if the namespace is going away anyway?
> 
This namespace is given to us in
WebKitTools/WebKitTestRunner/qt/PlatformWebViewQt.cpp.
It shouldn't be public so we might have to find a different way sooner or
later.
Having this contstructor in QWKContextPrivate and have a non-public friend
factory method kind of trick could do it.

> > WebKit2/UIProcess/API/qt/qwkcontext_p.h:37
> > +	 RefPtr<WebKit::WebPageNamespace> pageNamespace;
> > +
> 
> unneeded newspace
Fixed