[webkit-reviews] review granted: [Bug 50803] The commit-queue should file bugs about flaky tests it encounters : [Attachment 76166] upload the right patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 9 23:59:04 PST 2010


Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 50803: The commit-queue should file bugs about flaky tests it encounters
https://bugs.webkit.org/show_bug.cgi?id=50803

Attachment 76166: upload the right patch
https://bugs.webkit.org/attachment.cgi?id=76166&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76166&action=review

I fear this will annoy people too much, but it seems better than our previous
design.

> WebKitTools/Scripts/webkitpy/tool/bot/flakytestreporter.py:102
> +	       latest_flake_message = "The %s just saw %s flake while
processing patch %s on bug %s." % (self._bot_name, flaky_test, patch.id(),
patch.bug_id())

You should say attachment instead of patch to get autolinking to work.


More information about the webkit-reviews mailing list