[webkit-reviews] review denied: [Bug 35671] [Qt] Even if QNetworkRequest::AlwaysCache is set on a request, a page will be loaded from the network the first time : [Attachment 75649] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Jan Erik Hanssen
<jhanssen at gmail.com>'s request for review:
Bug 35671: [Qt] Even if QNetworkRequest::AlwaysCache is set on a request, a
page will be loaded from the network the first time
https://bugs.webkit.org/show_bug.cgi?id=35671

Attachment 75649: Patch
https://bugs.webkit.org/attachment.cgi?id=75649&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75649&action=review

> WebKit/qt/Api/qwebframe.cpp:867
> +	       switch (cacheLoadValue) {
> +	       case QNetworkRequest::AlwaysNetwork:
> +		   request.setCachePolicy(WebCore::ReloadIgnoringCacheData);
> +		   break;
> +	       case QNetworkRequest::PreferCache:
> +		   request.setCachePolicy(WebCore::ReturnCacheDataElseLoad);
> +		   break;
> +	       case QNetworkRequest::AlwaysCache:
> +		   request.setCachePolicy(WebCore::ReturnCacheDataDontLoad);
> +		   break;
> +	       case QNetworkRequest::PreferNetwork:
> +		   request.setCachePolicy(WebCore::UseProtocolCachePolicy);
> +		   break;

This would be much better as a helper function to convert the enum.  Then you
only need one request.setCachePolicy call and this function gets much cleaner.