[webkit-reviews] review denied: [Bug 50617] ValidityState's exposed functions should check if willValidate() is true before all : [Attachment 76162] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Dai Mikurube
<dmikurube at google.com>'s request for review:
Bug 50617: ValidityState's exposed functions should check if willValidate() is
true before all
https://bugs.webkit.org/show_bug.cgi?id=50617

Attachment 76162: Patch
https://bugs.webkit.org/attachment.cgi?id=76162&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76162&action=review

The patch is good enough for r+.  However I'd like to ask splitting the patch
into two:
 1. merge existing tests
 2. fix willValidate-related bugs.

> LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js:12
> +    if (disabled)
> +	   input.disabled = true;
> +    else
> +	   input.disabled = false;

You can write "input.disabled = !!disabled".