[webkit-reviews] review granted: [Bug 50791] Add CoreIPC coders for CF types : [Attachment 76139] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 9 17:21:25 PST 2010


Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 50791: Add CoreIPC coders for CF types
https://bugs.webkit.org/show_bug.cgi?id=50791

Attachment 76139: Patch
https://bugs.webkit.org/attachment.cgi?id=76139&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76139&action=review

> WebKit2/Platform/CoreIPC/ArgumentDecoder.h:66
> +	   COMPILE_ASSERT(sizeof(T) <= sizeof(uint64_t),
enum_type_must_not_be_larger_than_64_bits);

You could use COMPILE_ASSERT __is_enum(), in Clang only code.


More information about the webkit-reviews mailing list