[webkit-reviews] review granted: [Bug 50698] [GTK] Split webkitprivate.{cpp, h} in more manageable chunks : [Attachment 76103] split web inspector

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 9 17:16:00 PST 2010


Martin Robinson <mrobinson at webkit.org> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 50698: [GTK] Split webkitprivate.{cpp,h} in more manageable chunks
https://bugs.webkit.org/show_bug.cgi?id=50698

Attachment 76103: split web inspector
https://bugs.webkit.org/attachment.cgi?id=76103&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76103&action=review

> WebKit/gtk/webkit/webkitwebinspectorprivate.h:38
> +WEBKIT_API void webkit_web_inspector_execute_script(WebKitWebInspector*,
long, const gchar*);

I think here it makes sense to leave the variable names. Please add them back
before landing. This should eventually move to DumpRenderTreeSupport, but that
can be in another patch.


More information about the webkit-reviews mailing list