[webkit-reviews] review granted: [Bug 50698] [GTK] Split webkitprivate.{cpp, h} in more manageable chunks : [Attachment 76100] split WebKitNetworkRequest

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 9 17:02:56 PST 2010


Martin Robinson <mrobinson at webkit.org> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 50698: [GTK] Split webkitprivate.{cpp,h} in more manageable chunks
https://bugs.webkit.org/show_bug.cgi?id=50698

Attachment 76100: split WebKitNetworkRequest
https://bugs.webkit.org/attachment.cgi?id=76100&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76100&action=review

> WebKit/gtk/webkit/webkitnetworkrequest.cpp:264
> +WebKitNetworkRequest* kitNew(const WebCore::ResourceRequest&
resourceRequest)
> +{
> +    PlatformRefPtr<SoupMessage>
soupMessage(adoptPlatformRef(resourceRequest.toSoupMessage()));
> +    if (soupMessage)
> +	   return
WEBKIT_NETWORK_REQUEST(g_object_new(WEBKIT_TYPE_NETWORK_REQUEST, "message",
soupMessage.get(), NULL));
> +
> +    return WEBKIT_NETWORK_REQUEST(g_object_new(WEBKIT_TYPE_NETWORK_REQUEST,
"uri", resourceRequest.url().string().utf8().data(), NULL));
> +}
> +

It's a shame that the WebKitNetworkRequest doesn't store a copy of the original
resource request. If it's possible perhaps it would make sense to do that in
another patch. The kitNew name seems a little funky here, but makes sense.

> WebKit/gtk/webkit/webkitnetworkrequestprivate.h:28
> +WebCore::ResourceRequest core(WebKitNetworkRequest* request);

Please remove this variable name before landing.


More information about the webkit-reviews mailing list