[webkit-reviews] review denied: [Bug 36512] Expose constructor functions for instanceof checks of WebGL objects : [Attachment 76128] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 9 16:34:22 PST 2010


Kenneth Russell <kbr at google.com> has denied Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 36512: Expose constructor functions for instanceof checks of WebGL objects
https://bugs.webkit.org/show_bug.cgi?id=36512

Attachment 76128: patch
https://bugs.webkit.org/attachment.cgi?id=76128&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
As Chris points out the test really does need to ensure that attempts to call
these constructors throw exceptions. r- for this reason. Looks good otherwise.


More information about the webkit-reviews mailing list