[webkit-reviews] review denied: [Bug 49355] WebGLRenderingContext needs to zero textures and renderbuffers : [Attachment 76130] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 9 16:30:17 PST 2010


Kenneth Russell <kbr at google.com> has denied Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 49355: WebGLRenderingContext needs to zero textures and renderbuffers
https://bugs.webkit.org/show_bug.cgi?id=49355

Attachment 76130: Patch
https://bugs.webkit.org/attachment.cgi?id=76130&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=76130&action=review

The refactoring looks good but please clean up this one issue.

> WebCore/platform/graphics/GraphicsContext3D.h:477
> +    int texImage2DResourceSafe(unsigned target, unsigned level, unsigned
internalformat, unsigned width, unsigned height, unsigned border, unsigned
format, unsigned type);

Returning int is gross. Please make this return bool.


More information about the webkit-reviews mailing list