[webkit-reviews] review granted: [Bug 49982] Change EventHandler::dispatchMouseEvent code to use DOM traversal instead of render tree traversal : [Attachment 76122] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 49982: Change EventHandler::dispatchMouseEvent code to use DOM traversal
instead of render tree traversal
https://bugs.webkit.org/show_bug.cgi?id=49982

Attachment 76122: Patch
https://bugs.webkit.org/attachment.cgi?id=76122&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=76122&action=review

> WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

Need to remove this or replace it with an explanation of why there are no new
tests. The tools won’t allow this to be checked in with OOPS in it, and unlike
the Reviewed by line, the tools won’t fill in the value for us.

> WebCore/ChangeLog:12
> +	Walk up DOM/hosted tree rather than render tree.

Tab here. Won’t be able to land a patch with a tab in it.

> WebCore/page/EventHandler.cpp:1861
> +	   while (node) {
>	       if (node && node->isMouseFocusable()) {

No need to check node for null twice in a row here.