[webkit-reviews] review granted: [Bug 50768] Add a basic implementation of PDF support on Mac : [Attachment 76094] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 50768: Add a basic implementation of PDF support on Mac
https://bugs.webkit.org/show_bug.cgi?id=50768

Attachment 76094: Patch
https://bugs.webkit.org/attachment.cgi?id=76094&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76094&action=review

> WebKit2/UIProcess/API/mac/PDFViewController.h:48
> +    static PassOwnPtr<PDFViewController> create(WKView *wkView);

Parameter name is not needed.

> WebKit2/UIProcess/API/mac/PDFViewController.h:67
> +}

We usually put // namespace WebKit here.

> WebKit2/UIProcess/API/mac/WKView.mm:1001
> +- (void)_setPageHasCustomRepresentation:(BOOL)pageHasCustomRepresentation {

{ should be on the next line.

> WebKit2/UIProcess/API/mac/WKView.mm:1008
> +- (void)_didFinishLoadingDataForCustomRepresentation:(const
CoreIPC::DataReference&)dataReference {

Same here.