[webkit-reviews] review granted: [Bug 50666] Spatial Navigation: code clean up : [Attachment 75873] patch v1

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Antonio Gomes
<tonikitoo at webkit.org>'s request for review:
Bug 50666: Spatial Navigation: code clean up
https://bugs.webkit.org/show_bug.cgi?id=50666

Attachment 75873: patch v1
https://bugs.webkit.org/attachment.cgi?id=75873&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75873&action=review

> WebCore/page/SpatialNavigation.cpp:85
> +	   rect = nodeRectInAbsoluteCoordinates(n, true /* ignore border */);

Nit: I don't really like the boolean second argument of
nodeRectInAbsoluteCoordinates(). We should consider making the second argument
take enum values so that we an remove the comment /* ignore border */. This can
be done in a follow up bug.