[webkit-reviews] review granted: [Bug 50715] webkit-patch should warn users when they're using a 32-bit git on a 64-bit system : [Attachment 75977] move _check_git_architecture to after SCM.__init__

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 50715: webkit-patch should warn users when they're using a 32-bit git on a
64-bit system
https://bugs.webkit.org/show_bug.cgi?id=50715

Attachment 75977: move _check_git_architecture to after SCM.__init__
https://bugs.webkit.org/attachment.cgi?id=75977&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75977&action=review

> WebKitTools/ChangeLog:23
> +	   the code is.  I considered writing a test for the log message, but
it seemed not worth it.

I think testing _check_git_architecture is worthwhile just to ensure that the
code actually runs. Don't even need to verify the output. It helps avoid simple
programming errors (e.g. typos).