[webkit-reviews] review granted: [Bug 48926] Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK : [Attachment 75967] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted kalman at chromium.org's request for
review:
Bug 48926: Using BUG/BUGWK in test_expectations is error prone, should use
BUGCR/BUGWK
https://bugs.webkit.org/show_bug.cgi?id=48926

Attachment 75967: Patch
https://bugs.webkit.org/attachment.cgi?id=75967&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75967&action=review

This looks great!

> LayoutTests/ChangeLog:9
> +	For all test_expectations.txt files, change all occurrences of BUG to
> +	either BUGCR or BUGWK.

Indentation is off here. Use spaces, not tabs.

> WebKitTools/ChangeLog:9
> +	Add presubmit check that BUG isn't used, either BUGCR or BUGWK.

ditto re: spaces

>
WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:6
00
> +		   self._add_error(lineno, 'Bug must be either BUGCR or BUGWK
for test: %s' %

Nit: now there is also BUGV8_XXX