[webkit-reviews] review denied: [Bug 50674] IndexedDB: Numeric keys are floats. : [Attachment 76053] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Hans Wennborg
<hans at chromium.org>'s request for review:
Bug 50674: IndexedDB: Numeric keys are floats.
https://bugs.webkit.org/show_bug.cgi?id=50674

Attachment 76053: Patch
https://bugs.webkit.org/attachment.cgi?id=76053&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76053&action=review

> WebCore/storage/IDBFactoryBackendImpl.cpp:119
> +	   "INSERT INTO MetaData VALUES ('version', 2)",

I think we should probably just keep this as it was originally and let the
migrations bring it up to date so we dont' add antoher code path.

> WebCore/storage/IDBFactoryBackendImpl.cpp:153
> +	   query.finalize();

Whats this?  Should we be doing it elsewhere?