[webkit-reviews] review granted: [Bug 50738] [GTK] Choose a dictionary in case there is no one defined or the env LANG does not propose one : [Attachment 76043] Proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 50738: [GTK] Choose a dictionary in case there is no one defined or the env
LANG does not propose one
https://bugs.webkit.org/show_bug.cgi?id=50738

Attachment 76043: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=76043&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76043&action=review

Thank you! Please fix the remaining minor issues before landing.

> WebKit/gtk/webkit/webkitwebsettings.cpp:953
> +static void getAvilableDictionariesCallback(const char* const lang_tag,
const char* const provider_name, const char* const provider_desc, const char*
const provider_file, void* data)

Please change lang_tag to languageTag before landing. You should actually omit
provider_name, provider_desc, and provider_file to avoid a warning here too.

> WebKit/gtk/webkit/webkitwebsettings.cpp:955
> +    Vector<CString>* dicts = static_cast< Vector<CString>* >(data);

Please remove the extra space after the static_cast< before landing.