[webkit-reviews] review granted: [Bug 50739] [GTK] Add hasSpellingMarker support to the DRT : [Attachment 76031] Proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 50739: [GTK] Add hasSpellingMarker support to the DRT
https://bugs.webkit.org/show_bug.cgi?id=50739

Attachment 76031: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=76031&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76031&action=review

> WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:418
> +    return coreFrame->editor()->selectionStartHasSpellingMarkerFor(from,
length);

Maybe just core(frame)->... here before landing.

> WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h:74
> +    static bool webkitWebFrameSelectionHasSpellingMarker(WebKitWebFrame
*frame, gint from, gint length);

Please remove the variable name before landing.