[webkit-reviews] review denied: [Bug 50684] Default styling rules for the figure and figcaption elements : [Attachment 75896] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 9 01:47:46 PST 2010


Maciej Stachowiak <mjs at apple.com> has denied  review:
Bug 50684: Default styling rules for the figure and figcaption elements
https://bugs.webkit.org/show_bug.cgi?id=50684

Attachment 75896: Patch
https://bugs.webkit.org/attachment.cgi?id=75896&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75896&action=review

Also it looks like the test cases don't test the styles.

> WebCore/css/html.css:90
>      margin: 1__qem 40px 1em 40px

I don't think this rule is right for figure. The 1__qem invokes a quirk in
quirks mode that is needed for historical reasons for blockquote, but there is
no need to have the same quirk for figure.


More information about the webkit-reviews mailing list