[webkit-reviews] review denied: [Bug 50365] Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Linux and Windows : [Attachment 76016] An initial patch to make Chromium Linux render vertical text correctly
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 8 22:51:41 PST 2010
Kent Tamura <tkent at chromium.org> has denied Koan-Sin Tan
<koansin.tan at gmail.com>'s request for review:
Bug 50365: Glyphs in vertical text tests are rotated 90 degrees clockwise on
Chromium Linux and Windows
https://bugs.webkit.org/show_bug.cgi?id=50365
Attachment 76016: An initial patch to make Chromium Linux render vertical text
correctly
https://bugs.webkit.org/attachment.cgi?id=76016&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76016&action=review
style comments.
> WebCore/platform/graphics/chromium/FontPlatformDataLinux.cpp:83
> +#if 0
Unused code should be removed.
> WebCore/platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:65
> + if (!error)
Should add { } because the block has two physical lines.
> WebCore/platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:70
> + } else
> + // if there is no GSUB table, treat it as not covered
> + error = 0Xffff;
ditto.
More information about the webkit-reviews
mailing list