[webkit-reviews] review granted: [Bug 47397] TextResourceDecoder::checkForHeadCharset can look way past the limit. : [Attachment 75929] updated patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Jenn Braithwaite
<jennb at chromium.org>'s request for review:
Bug 47397: TextResourceDecoder::checkForHeadCharset can look way past the
limit.
https://bugs.webkit.org/show_bug.cgi?id=47397

Attachment 75929: updated patch
https://bugs.webkit.org/attachment.cgi?id=75929&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75929&action=review

Thanks!

> WebCore/html/parser/HTMLMetaCharsetParser.cpp:55
> +const char* charsetString = "charset";
> +const size_t charsetLength = sizeof("charset") - 1;

We should probably put these in an anonymous namespace so we don't leak the
symbols (or maybe const stops that?)