[webkit-reviews] review granted: [Bug 47901] fast/canvas/canvas-getImageData-negative-source.html fails on Mac : [Attachment 75998] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 47901: fast/canvas/canvas-getImageData-negative-source.html fails on Mac
https://bugs.webkit.org/show_bug.cgi?id=47901

Attachment 75998: Patch
https://bugs.webkit.org/attachment.cgi?id=75998&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75998&action=review

Looks fine.

> WebCore/html/HTMLCanvasElement.cpp:349
>  #if PLATFORM(SKIA)
> -    if (wf > MaxSkiaDim || hf > MaxSkiaDim)
> +    if (width > MaxSkiaDim || height > MaxSkiaDim)
>	   return IntSize();
>  #endif

Really? Why does Skia need this at this level? Why doesn’t any other graphics
system need this?