[webkit-reviews] review denied: [Bug 50663] Support validation API for <object> : [Attachment 75997] Patch V0

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Kenichi Ishibashi
<bashi at google.com>'s request for review:
Bug 50663: Support validation API for <object>
https://bugs.webkit.org/show_bug.cgi?id=50663

Attachment 75997: Patch V0
https://bugs.webkit.org/attachment.cgi?id=75997&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75997&action=review

> LayoutTests/fast/forms/ValidityState-001-expected.txt:7
> +SUCCESS
> +SUCCESS
> +SUCCESS
>  SUCCESS

The test result readability is bad.
However it's ok.  You just followed the existing test.

> LayoutTests/fast/forms/checkValidity-001-expected.txt:10
> +PASS v[i].checkValidity() is true
> +PASS v[i].checkValidity() is true
> +PASS v[i].checkValidity() is true
>  PASS v[i].checkValidity() is true

ditto.

> LayoutTests/fast/forms/script-tests/setCustomValidity-existence.js:19
> +    + '</form>';
> +var controls = document.getElementsByName('victim');
> +    for (var i = 0; i < controls.length; i++)
> +	   shouldBe('typeof controls[i].setCustomValidity', '"function"');

The indentation looks wrong.

The test result readability is not good.
shouldBe('document.getElementsByTagName("input")[0].setCustomValidity',
'"function"');
shouldBe('document.getElementsByTagName("textarea")[0].setCustomValidity',
'"function"');
...
is better.

> LayoutTests/fast/forms/willvalidate-expected.txt:51
> +Keygen element
> +FIXME: Let keygen.willValidate be false because <keygen> is barred from
constraint validation.
> +FAIL document.getElementsByTagName("keygen")[0].willValidate should be
false. Was true.

We should remove test cases for keygen, or should expand this bug so that it
includes <keygen> fix.