[webkit-reviews] review granted: [Bug 50726] Need a way to get a WKBundleFrameRef from JS HTMLIFrameElement : [Attachment 75996] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 50726: Need a way to get a WKBundleFrameRef from JS HTMLIFrameElement
https://bugs.webkit.org/show_bug.cgi?id=50726

Attachment 75996: Patch
https://bugs.webkit.org/attachment.cgi?id=75996&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75996&action=review

> WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:63
> +    PassRefPtr<WebFrame> copyDocumentFrame();
> +    PassRefPtr<WebFrame> copyHTMLFrameElementContentFrame();
> +    PassRefPtr<WebFrame> copyHTMLIFrameElementContentFrame();

When the return type is a PassRefPtr, I’m not sure it makes all that much sense
to use copy naming when there’s no actual copying going on. There’s no need to
use the copy rule for naming when you have a smart pointer class involved.