[webkit-reviews] review denied: [Bug 50341] Progressbar rendering crash : [Attachment 75900] Address reviews
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 8 15:57:39 PST 2010
Kent Tamura <tkent at chromium.org> has denied sadrul at chromium.org's request for
review:
Bug 50341: Progressbar rendering crash
https://bugs.webkit.org/show_bug.cgi?id=50341
Attachment 75900: Address reviews
https://bugs.webkit.org/attachment.cgi?id=75900&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75900&action=review
> LayoutTests/ChangeLog:8
> + The scaled tile width can be very small at times (e.g. with 'style:
font 1
> + required'). So use a minimum width of 1 instead of using 0 (which
leads to a
> + crash).
> + https://bugs.webkit.org/show_bug.cgi?id=50341
Please make this synchronized with WebCore/ChangeLog
>
LayoutTests/fast/dom/HTMLProgressElement/progress-element-with-style-crash.html
:13
> + window.setTimeout(function() {
> + if (window.layoutTestController)
> + layoutTestController.notifyDone();
> + }, 10);
Would you add a comment about the reason of setTimeout()?
More information about the webkit-reviews
mailing list