[webkit-reviews] review granted: [Bug 43455] [Qt]: Implement Application Cache Quotas : [Attachment 75961] Patch to fix skipped layout test origin-quota.html

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 8 14:43:08 PST 2010


Joseph Pecoraro <joepeck at webkit.org> has granted
krithigassree.sambamurthy at nokia.com's request for review:
Bug 43455: [Qt]: Implement Application Cache Quotas
https://bugs.webkit.org/show_bug.cgi?id=43455

Attachment 75961: Patch to fix skipped layout test origin-quota.html
https://bugs.webkit.org/attachment.cgi?id=75961&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75961&action=review

> WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:1030
> +void DumpRenderTree::dumpApplicationCacheQuota(QWebSecurityOrigin* origin,
quint64 defaultOriginQuota)
> +{
> +
> +    if (!m_controller->shouldDumpApplicationCacheDelegateCallbacks())

Doh. I meant the newline above!

r=me. Wrong newline removed, but that is okay. It would be unnecessary
to have you attach a new patch for just a newline. Do you have someone who
can land these for you (and possibly fix this newline) or do you typically
use the commit queue? I can help you with either.


More information about the webkit-reviews mailing list