[webkit-reviews] review denied: [Bug 43455] [Qt]: Implement Application Cache Quotas : [Attachment 75819] Patch to fix skipped layout test origin-quota.html

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has denied
krithigassree.sambamurthy at nokia.com's request for review:
Bug 43455: [Qt]: Implement Application Cache Quotas
https://bugs.webkit.org/show_bug.cgi?id=43455

Attachment 75819: Patch to fix skipped layout test origin-quota.html
https://bugs.webkit.org/attachment.cgi?id=75819&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75819&action=review

r- only because LayoutTests is missing a ChangeLog entry. Otherwise it looks
good
to me. Please attach a new patch with that ChangeLog and the style fix!

You should be able to generate the ChangeLog entry by changing directory
into the LayoutTests directory and running:

    WebKitTools/Scripts/prepare-Changelog -b 43455

Note that it will have a slightly different format than your existing
ChangeLog entries:

	 Bug 43455 -  [Qt]: Implement Application Cache Quotas
	 https://bugs.webkit.org/show_bug.cgi?id=43455

will probably be just:

	 [Qt]: Implement Application Cache Quotas
	 https://bugs.webkit.org/show_bug.cgi?id=43455

I'd recommend the second approach, but as long as they are consistent
it'll be fine. Thanks for fixing this!

> WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:1030
> +void DumpRenderTree::dumpApplicationCacheQuota(QWebSecurityOrigin* origin,
quint64 defaultOriginQuota)
> +{
> +
> +    if (!m_controller->shouldDumpApplicationCacheDelegateCallbacks())

Nit: remove the newline here.