[webkit-reviews] review granted: [Bug 50700] Fix some clang++ warnings (some of which were actual bugs) : [Attachment 75949] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 50700: Fix some clang++ warnings (some of which were actual bugs)
https://bugs.webkit.org/show_bug.cgi?id=50700

Attachment 75949: Patch
https://bugs.webkit.org/attachment.cgi?id=75949&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75949&action=review

> WebCore/page/mac/DragControllerMac.mm:57
> +    if (!m_documentUnderMouse ||
(![[m_page->mainFrame()->view()->getOuterView() window] attachedSheet] 
> +	   && [dragData->platformData() draggingSource] !=
m_page->mainFrame()->view()->getOuterView()))

This one was not a bug. You should not call it a bug in the change log.

> WebCore/page/mac/EventHandlerMac.mm:762
> +    if (applicationIsSafari() && (document->url().protocolIs("feed") ||
document->url().protocolIs("feeds")))

This one was!