[webkit-reviews] review canceled: [Bug 50550] [Qt] QWebPage::createWindow does not recieve the proper window type... : [Attachment 75780] Proposed patch v2

[bugzilla-daemon at webkit.org]

Dawit A. <adawit at kde.org> has canceled Dawit A. <adawit at kde.org>'s request for
review:
Bug 50550: [Qt] QWebPage::createWindow does not recieve the proper window
type...
https://bugs.webkit.org/show_bug.cgi?id=50550

Attachment 75780: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=75780&action=review

------- Additional Comments from Dawit A. <adawit at kde.org>
First disregard my ignorant comment regarding the purpose of the WebModalDialog
type. I now see that its purpose is to handle the "window.showModalDialog"
Javascript calls and not the "modal" feature of the "window.open" ones. Anyhow,
here is the proper implementation I promised with the following new
modifications:

- Completely abondon the changes made in the WindowFeatures class as they are
not necessary.

- Add a new WebWindowType enum, WebDialog, to make reimplementators of
QWebPage::createWindow aware of the kind of window they should create when that
function is invoked. In this case WebDialog is used to convey the fact that the
window created MUST be a completely new window and not just another tab in the
current window as might be the case if type was set to WebBrowserWindow. This
makes it possible to provide implementation consistent with other browsers.

- For window.open javascript calles, the WebWindowType parameter of
QWebPage::createWindow will be set to WebWindowBrowser only when the windows
feature portion the afformentioned javascript call is empty. Again, this is
consistent with the implementation in other browsers.