[webkit-reviews] review granted: [Bug 50656] WebKit2: Implement WebChromeClient::exceededDatabaseQuota : [Attachment 75910] Patch (with Qt build fix and windows version of MiniBrowser build fix)

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Jessie Berlin
<jberlin at webkit.org>'s request for review:
Bug 50656: WebKit2: Implement WebChromeClient::exceededDatabaseQuota
https://bugs.webkit.org/show_bug.cgi?id=50656

Attachment 75910: Patch (with Qt build fix and windows version of MiniBrowser
build fix)
https://bugs.webkit.org/attachment.cgi?id=75910&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75910&action=review

> WebKit2/UIProcess/API/qt/qwkpage.cpp:364
> +	   0,  /* pageDidScroll */
> +	   0 /* exceededDatabaseQuota */

Maybe you should match the existing spacing here?

> WebKitTools/WebKitTestRunner/TestController.cpp:139
> +	   0, // pageDidScroll
> +	   0 // exceededDatabaseQuota

And here.

> WebKitTools/WebKitTestRunner/TestController.cpp:242
> +	   0, // pageDidScroll
> +	   0 // exceededDatabaseQuota

And here.