[webkit-reviews] review canceled: [Bug 50493] Web Inspector: [Extension API] add support for adding/overriding HTTP request headers : [Attachment 75556] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 8 07:08:59 PST 2010
Pavel Feldman <pfeldman at chromium.org> has canceled Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 50493: Web Inspector: [Extension API] add support for adding/overriding
HTTP request headers
https://bugs.webkit.org/show_bug.cgi?id=50493
Attachment 75556: patch
https://bugs.webkit.org/attachment.cgi?id=75556&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75556&action=review
> WebCore/inspector/InspectorController.h:178
> + void applyOverrideHeaders(ResourceRequest&);
Can you do this in willSendRequest instead?
> WebCore/inspector/front-end/ExtensionServer.js:161
> + var allHeaders = {};
Wrong indent
More information about the webkit-reviews
mailing list