[webkit-reviews] review granted: [Bug 50676] [GTK] Layering violation in ContextMenuGtk.cpp : [Attachment 75884] Patch for this issue

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 8 05:52:42 PST 2010


John Sullivan <sullivan at apple.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 50676: [GTK] Layering violation in ContextMenuGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=50676

Attachment 75884: Patch for this issue
https://bugs.webkit.org/attachment.cgi?id=75884&action=review

------- Additional Comments from John Sullivan <sullivan at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75884&action=review

> WebKit/gtk/webkit/webkitwebview.cpp:268
> +static void popupMenuItemActivated(GtkMenuItem* item, ContextMenuController*
controller)

To keep the terminology consistent, I suggest using "contextMenu" rather than
"popupMenu" in the name of this function.


More information about the webkit-reviews mailing list