[webkit-reviews] review denied: [Bug 50679] Web Inspector: eliminate SourceFrameDelegate by passing scripts to SourceFrame constructor : [Attachment 75887] Patch.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 50679: Web Inspector: eliminate SourceFrameDelegate by passing scripts to
SourceFrame constructor
https://bugs.webkit.org/show_bug.cgi?id=50679

Attachment 75887: Patch.
https://bugs.webkit.org/attachment.cgi?id=75887&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75887&action=review

> WebCore/inspector/front-end/Resource.js:512
>	   script.resource = this;

Do we actually use this link?

> WebCore/inspector/front-end/Script.js:88
> +	  
this.dispatchEventToListeners(WebInspector.Script.Events.SourceChanged,
revertCallback || function() {});

callback should not be a part of the event data - what if there are several
listeners? what should they do to callback? r- for this.