[webkit-reviews] review canceled: [Bug 50619] Glyphs in vertical text tests are rotated 90 degrees clockwise on WebKitGtk : [Attachment 75816] a patch to make vertical text work on WebKitGtk

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 7 20:18:37 PST 2010


Koan-Sin Tan <koansin.tan at gmail.com> has canceled Koan-Sin Tan
<koansin.tan at gmail.com>'s request for review:
Bug 50619: Glyphs in vertical text tests are rotated 90 degrees clockwise on
WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=50619

Attachment 75816: a patch to make vertical text work on WebKitGtk
https://bugs.webkit.org/attachment.cgi?id=75816&action=review

------- Additional Comments from Koan-Sin Tan <koansin.tan at gmail.com>
Modified according to Martin's comments except rotating font when it is
created, 'cause I don't know how to do that.

Error handling in substituteWithVerticalGlyphs() has some redundant code,
because if I use goto, then there will be "jump to label crosses
initialization" problems.


More information about the webkit-reviews mailing list