[webkit-reviews] review requested: [Bug 50647] Migrate buildbot.py from xmlrpclib to json : [Attachment 75856] add blank line to ChangeLog, fix mockup of build_dictionary

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 7 18:10:01 PST 2010


William Siegrist <wsiegrist at apple.com> has asked  for review:
Bug 50647: Migrate buildbot.py from xmlrpclib to json
https://bugs.webkit.org/show_bug.cgi?id=50647

Attachment 75856: add blank line to ChangeLog, fix mockup of build_dictionary
https://bugs.webkit.org/attachment.cgi?id=75856&action=review

------- Additional Comments from William Siegrist <wsiegrist at apple.com>
No, I had not run test-webkitpy, but now I know better. It turns out I needed
to update the mockup of build_dictionary to match the new layout of the json
data. I also fixed the ChangeLog (again).


More information about the webkit-reviews mailing list