[webkit-reviews] review denied: [Bug 49388] Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations : [Attachment 75842] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 7 14:13:25 PST 2010
Simon Fraser (smfr) <simon.fraser at apple.com> has denied Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 49388: Share code between Mac (CA) and Windows (CACF) GraphicsLayer
implementations
https://bugs.webkit.org/show_bug.cgi?id=49388
Attachment 75842: Patch
https://bugs.webkit.org/attachment.cgi?id=75842&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75842&action=review
New files are missing from the patch.
> JavaScriptCore/wtf/Platform.h:535
> +#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(WIN)
> +#define WTF_PLATFORM_CA 1
> +#endif
Are you sure this won't affect other ports on Windows?
More information about the webkit-reviews
mailing list