[webkit-reviews] review granted: [Bug 50586] Layering Violation in ContextMenu - member variable of type HitTestResult : [Attachment 75839] [PATCH] Mac layering violation

[bugzilla-daemon at webkit.org]

John Sullivan <sullivan at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 50586: Layering Violation in ContextMenu - member variable of type
HitTestResult
https://bugs.webkit.org/show_bug.cgi?id=50586

Attachment 75839: [PATCH] Mac layering violation
https://bugs.webkit.org/attachment.cgi?id=75839&action=review

------- Additional Comments from John Sullivan <sullivan at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75839&action=review

> WebKit/mac/WebView/WebHTMLView.mm:3281
> +    for (NSInteger i = 0; i < [menu numberOfItems]; ++i) {

You should use a local variable for the result of [menu numberOfItems] to avoid
unnecessary ObjC dispatch.