[webkit-reviews] review requested: [Bug 49332] Do not allow access to existing HTML5 databases in private browsing mode : [Attachment 75831] [PATCH] separate read-only transaction state from private browsing no read-write state

[bugzilla-daemon at webkit.org]

Anton D'Auria <adauria at apple.com> has asked  for review:
Bug 49332: Do not allow access to existing HTML5 databases in private browsing
mode
https://bugs.webkit.org/show_bug.cgi?id=49332

Attachment 75831: [PATCH] separate read-only transaction state from private
browsing no read-write state
https://bugs.webkit.org/attachment.cgi?id=75831&action=review

------- Additional Comments from Anton D'Auria <adauria at apple.com>
Previously, read-only transactions and private browsing mode were represented
by the same SQLStatement and DatabaseAuthorizer states. This patch removes the
m_readOnly member variable from SQLStatement and DatabaseAuthorizer, and
replaces it with m_permissions whose bit fields are initialized by a
DatabaseAuthorizer enum Permissions (ReadWrite, ReadOnly, NoAccess). A
read-only transaction sets permissions to ReadOnly, and if
!m_database->scriptExecutionContext()->allowDatabaseAccess(), then permissions
also set to NoAccess.