[webkit-reviews] review granted: [Bug 47142] Spatial navigation not Working for Map and Area Tags : [Attachment 75631] Patch.

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Yael <yael.aharon at nokia.com>'s
request for review:
Bug 47142: Spatial navigation not Working for Map and Area Tags
https://bugs.webkit.org/show_bug.cgi?id=47142

Attachment 75631: Patch.
https://bugs.webkit.org/attachment.cgi?id=75631&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75631&action=review

> WebCore/page/SpatialNavigation.h:123
> +    Node* visibleNode;
>      Node* enclosingScrollableBox;
> +    Node* focusableNode;

Please add a comment in the code explaining the difference between visibleNode
and focusableNode, and when to use one or the other.

I would also like to see asserts in the code if one is trying to use one, but
should be using the other.