[webkit-reviews] review denied: [Bug 49914] Merge GraphicsContextPrivate into GraphicsContext : [Attachment 75799] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Renata Hodovan <reni at webkit.org>'s
request for review:
Bug 49914: Merge GraphicsContextPrivate into GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=49914

Attachment 75799: Patch
https://bugs.webkit.org/attachment.cgi?id=75799&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75799&action=review

> WebCore/ChangeLog:9
> +	   and	m_common member became unnecessary. They are removed.

Double space after 'and'.
s/m_common member/m_common/

> WebCore/ChangeLog:10
> +	   Add two virtual methods to GraphicsContext: platformInit() and
platformDestroy(), which

Not virtual anymore.

> WebCore/platform/graphics/GraphicsContext.h:208
> +	   void platformInit(PlatformGraphicsContext*);
> +	   void platformDestroy();

These methods should be private.

> WebCore/platform/graphics/GraphicsContext.h:245
> +	   const GraphicsContextState& state();

Should be "const GraphicsContext& state() const" since the method doesn't
modify any GraphicsContext members.

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:75
> +    GraphicsContextState state = context->state();

Avoid the unnecessary copy:
const GraphicsContextState& state = context->state();

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:96
> +    GraphicsContextState state = context->state();

Ditto.